Skip to content

chore: bump swc to 27.0.4 #10660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
GiveMe-A-Name merged 3 commits into from
Jun 14, 2025
Merged

chore: bump swc to 27.0.4 #10660

GiveMe-A-Name merged 3 commits into from
Jun 14, 2025

Conversation

@GiveMe-A-Name
Copy link
Member

@GiveMe-A-Name GiveMe-A-Name commented Jun 13, 2025

Summary

  • Update SWC dependencies to latest version

SWC fixs dce bug, more detail see: CHANGELOG-CORE.md

Relative PR

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link

netlify bot commented Jun 13, 2025 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 8a1cfb7
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/684c196037a36e0008d84129

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Jun 13, 2025
@GiveMe-A-Name GiveMe-A-Name marked this pull request as draft June 13, 2025 09:48
@codspeed-hq
Copy link

codspeed-hq bot commented Jun 13, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #10660 will not alter performance

Comparing chore/bump-swc (8a1cfb7) with main (61fd95a)

🎉 Hooray! codspeed-node just leveled up to 4.0.1!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 12 untouched benchmarks

@GiveMe-A-Name GiveMe-A-Name marked this pull request as ready for review June 13, 2025 10:21
@hardfist
Copy link
Contributor

hardfist commented Jun 13, 2025

should run bench

@github-actions
Copy link
Contributor

github-actions bot commented Jun 13, 2025 •
edited
Loading

📝 Benchmark detail: Open

Name Base (2025-06-13 3c8b4b8) Current Change
10000_big_production-mode_disable-minimize + exec 35.3 s ± 419 ms 34.4 s ± 135 ms -2.58 %
10000_development-mode + exec 1.88 s ± 16 ms 1.78 s ± 40 ms -5.44 %
10000_development-mode_hmr + exec 711 ms ± 14 ms 677 ms ± 10 ms -4.83 %
10000_production-mode + exec 2.38 s ± 36 ms 2.21 s ± 60 ms -7.01 %
10000_production-mode_persistent-cold + exec 2.54 s ± 51 ms 2.36 s ± 26 ms -7.11 %
10000_production-mode_persistent-hot + exec 1.81 s ± 22 ms 1.65 s ± 23 ms -9.26 %
arco-pro_development-mode + exec 1.81 s ± 102 ms 1.8 s ± 90 ms -0.23 %
arco-pro_development-mode_hmr + exec 369 ms ± 2.2 ms 369 ms ± 0.77 ms -0.06 %
arco-pro_production-mode + exec 3.39 s ± 114 ms 3.31 s ± 71 ms -2.49 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.5 s ± 125 ms 3.42 s ± 82 ms -2.47 %
arco-pro_production-mode_persistent-cold + exec 3.48 s ± 66 ms 3.38 s ± 175 ms -2.98 %
arco-pro_production-mode_persistent-hot + exec 2.07 s ± 98 ms 2.02 s ± 99 ms -2.16 %
arco-pro_production-mode_traverse-chunk-modules + exec 3.42 s ± 40 ms 3.34 s ± 104 ms -2.46 %
large-dyn-imports_development-mode + exec 2.1 s ± 44 ms 2.01 s ± 27 ms -4.10 %
large-dyn-imports_production-mode + exec 2.11 s ± 24 ms 2 s ± 20 ms -5.51 %
threejs_development-mode_10x + exec 1.48 s ± 58 ms 1.43 s ± 37 ms -3.52 %
threejs_development-mode_10x_hmr + exec 834 ms ± 23 ms 810 ms ± 7.7 ms -2.87 %
threejs_production-mode_10x + exec 4.84 s ± 192 ms 4.72 s ± 50 ms -2.54 %
threejs_production-mode_10x_persistent-cold + exec 4.94 s ± 49 ms 4.87 s ± 23 ms -1.51 %
threejs_production-mode_10x_persistent-hot + exec 4.26 s ± 114 ms 4.14 s ± 58 ms -2.86 %
10000_big_production-mode_disable-minimize + rss memory 9286 MiB ± 182 MiB 9540 MiB ± 34.4 MiB +2.74 %
10000_development-mode + rss memory 651 MiB ± 31.2 MiB 742 MiB ± 36.5 MiB +13.97 %
10000_development-mode_hmr + rss memory 791 MiB ± 11 MiB 833 MiB ± 11.5 MiB +5.23 %
10000_production-mode + rss memory 643 MiB ± 83.5 MiB 732 MiB ± 62.1 MiB +13.79 %
10000_production-mode_persistent-cold + rss memory 761 MiB ± 53.6 MiB 861 MiB ± 76.2 MiB +13.13 %
10000_production-mode_persistent-hot + rss memory 774 MiB ± 43.5 MiB 861 MiB ± 57.3 MiB +11.24 %
arco-pro_development-mode + rss memory 607 MiB ± 69.3 MiB 660 MiB ± 73.2 MiB +8.73 %
arco-pro_development-mode_hmr + rss memory 497 MiB ± 43.2 MiB 532 MiB ± 24.6 MiB +7.08 %
arco-pro_production-mode + rss memory 722 MiB ± 97.2 MiB 783 MiB ± 76.9 MiB +8.44 %
arco-pro_production-mode_generate-package-json-webpack-plugin + rss memory 747 MiB ± 80.9 MiB 797 MiB ± 80.9 MiB +6.78 %
arco-pro_production-mode_persistent-cold + rss memory 816 MiB ± 124 MiB 927 MiB ± 58.7 MiB +13.62 %
arco-pro_production-mode_persistent-hot + rss memory 665 MiB ± 71.7 MiB 785 MiB ± 91.2 MiB +18.09 %
arco-pro_production-mode_traverse-chunk-modules + rss memory 712 MiB ± 83.1 MiB 761 MiB ± 69.2 MiB +6.87 %
large-dyn-imports_development-mode + rss memory 695 MiB ± 19.5 MiB 752 MiB ± 21.4 MiB +8.18 %
large-dyn-imports_production-mode + rss memory 575 MiB ± 5.26 MiB 618 MiB ± 27.7 MiB +7.54 %
threejs_development-mode_10x + rss memory 658 MiB ± 12.3 MiB 816 MiB ± 41.7 MiB +24.01 %
threejs_development-mode_10x_hmr + rss memory 862 MiB ± 46.8 MiB 965 MiB ± 81.5 MiB +12.01 %
threejs_production-mode_10x + rss memory 920 MiB ± 58 MiB 1054 MiB ± 65.8 MiB +14.55 %
threejs_production-mode_10x_persistent-cold + rss memory 1004 MiB ± 26.4 MiB 1199 MiB ± 45.2 MiB +19.51 %
threejs_production-mode_10x_persistent-hot + rss memory 866 MiB ± 36.2 MiB 973 MiB ± 15.4 MiB +12.43 %

@chenjiahan chenjiahan requested a review from CPunisher June 14, 2025 09:08
@github-actions
Copy link
Contributor

github-actions bot commented Jun 14, 2025 •
edited
Loading

📝 Benchmark detail: Open

Name Base (2025-06-14 430b5ad) Current Change
10000_big_production-mode_disable-minimize + exec 34.8 s ± 741 ms 34.8 s ± 168 ms -0.17 %
10000_development-mode + exec 1.8 s ± 23 ms 1.79 s ± 25 ms -0.57 %
10000_development-mode_hmr + exec 692 ms ± 4.5 ms 682 ms ± 16 ms -1.47 %
10000_production-mode + exec 2.21 s ± 40 ms 2.2 s ± 38 ms -0.25 %
10000_production-mode_persistent-cold + exec 2.51 s ± 681 ms 2.36 s ± 31 ms -6.14 %
10000_production-mode_persistent-hot + exec 1.63 s ± 32 ms 1.66 s ± 51 ms +1.73 %
arco-pro_development-mode + exec 1.76 s ± 86 ms 1.8 s ± 68 ms +2.13 %
arco-pro_development-mode_hmr + exec 369 ms ± 0.66 ms 369 ms ± 0.69 ms +0.06 %
arco-pro_production-mode + exec 3.25 s ± 99 ms 3.32 s ± 66 ms +1.92 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.34 s ± 113 ms 3.41 s ± 86 ms +2.07 %
arco-pro_production-mode_persistent-cold + exec 3.31 s ± 61 ms 3.4 s ± 70 ms +2.78 %
arco-pro_production-mode_persistent-hot + exec 1.96 s ± 104 ms 2.03 s ± 66 ms +3.26 %
arco-pro_production-mode_traverse-chunk-modules + exec 3.26 s ± 24 ms 3.33 s ± 52 ms +2.01 %
large-dyn-imports_development-mode + exec 2.02 s ± 59 ms 2.01 s ± 33 ms -0.58 %
large-dyn-imports_production-mode + exec 2.02 s ± 16 ms 2.01 s ± 30 ms -0.51 %
threejs_development-mode_10x + exec 1.43 s ± 39 ms 1.43 s ± 26 ms -0.08 %
threejs_development-mode_10x_hmr + exec 806 ms ± 9.4 ms 811 ms ± 9.8 ms +0.56 %
threejs_production-mode_10x + exec 4.57 s ± 28 ms 4.75 s ± 42 ms +3.84 %
threejs_production-mode_10x_persistent-cold + exec 4.7 s ± 37 ms 4.88 s ± 42 ms +3.99 %
threejs_production-mode_10x_persistent-hot + exec 3.98 s ± 48 ms 4.15 s ± 34 ms +4.36 %
10000_big_production-mode_disable-minimize + rss memory 9598 MiB ± 76.4 MiB 9387 MiB ± 67.6 MiB -2.19 %
10000_development-mode + rss memory 741 MiB ± 57.4 MiB 734 MiB ± 10.1 MiB -0.91 %
10000_development-mode_hmr + rss memory 867 MiB ± 47.9 MiB 828 MiB ± 29 MiB -4.52 %
10000_production-mode + rss memory 745 MiB ± 44.7 MiB 735 MiB ± 46.7 MiB -1.25 %
10000_production-mode_persistent-cold + rss memory 911 MiB ± 47.6 MiB 883 MiB ± 79.3 MiB -3.05 %
10000_production-mode_persistent-hot + rss memory 880 MiB ± 79.2 MiB 883 MiB ± 37.8 MiB +0.34 %
arco-pro_development-mode + rss memory 662 MiB ± 32.5 MiB 670 MiB ± 56.4 MiB +1.21 %
arco-pro_development-mode_hmr + rss memory 556 MiB ± 41.2 MiB 575 MiB ± 34 MiB +3.45 %
arco-pro_production-mode + rss memory 808 MiB ± 90.2 MiB 786 MiB ± 84.2 MiB -2.72 %
arco-pro_production-mode_generate-package-json-webpack-plugin + rss memory 803 MiB ± 77.5 MiB 783 MiB ± 23.8 MiB -2.51 %
arco-pro_production-mode_persistent-cold + rss memory 930 MiB ± 110 MiB 917 MiB ± 42.2 MiB -1.47 %
arco-pro_production-mode_persistent-hot + rss memory 796 MiB ± 70 MiB 792 MiB ± 25.6 MiB -0.48 %
arco-pro_production-mode_traverse-chunk-modules + rss memory 799 MiB ± 95.5 MiB 796 MiB ± 93.4 MiB -0.34 %
large-dyn-imports_development-mode + rss memory 752 MiB ± 12.8 MiB 741 MiB ± 5.85 MiB -1.46 %
large-dyn-imports_production-mode + rss memory 614 MiB ± 12.1 MiB 613 MiB ± 19.2 MiB -0.16 %
threejs_development-mode_10x + rss memory 827 MiB ± 81.2 MiB 839 MiB ± 90.8 MiB +1.41 %
threejs_development-mode_10x_hmr + rss memory 964 MiB ± 93.9 MiB 949 MiB ± 85.5 MiB -1.54 %
threejs_production-mode_10x + rss memory 1051 MiB ± 76.1 MiB 1077 MiB ± 105 MiB +2.46 %
threejs_production-mode_10x_persistent-cold + rss memory 1165 MiB ± 80.2 MiB 1163 MiB ± 42.7 MiB -0.17 %
threejs_production-mode_10x_persistent-hot + rss memory 957 MiB ± 42.1 MiB 956 MiB ± 36.9 MiB -0.17 %

@CPunisher
Copy link
Contributor

CPunisher commented Jun 14, 2025

Accept if the known performance regression of minifier is acceptable.

@GiveMe-A-Name GiveMe-A-Name merged commit 642d85f into main Jun 14, 2025
38 of 40 checks passed
@GiveMe-A-Name GiveMe-A-Name deleted the chore/bump-swc branch June 14, 2025 11:45
@chenjiahan
Copy link
Member

chenjiahan commented Jun 14, 2025

yeah, smaller bundle size is more important than build performance and we can improve minifier performance through subsequent optimizations.

@CPunisher CPunisher mentioned this pull request Jun 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CPunisher CPunisher CPunisher approved these changes

Assignees

No one assigned

Labels

team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@GiveMe-A-Name @hardfist @CPunisher @chenjiahan