Skip to content

Conversation

@SyMind
Copy link
Member

@SyMind SyMind commented Jun 12, 2025

Summary

When removing files from the project:

  1. detect directly affected modules
  2. and then we unnecessary to rebuild the parent modules, only rebuild the relate ModuleDependency.

image

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link

netlify bot commented Jun 12, 2025

Deploy Preview for rspack ready!

Name Link
🔨 Latest commit fea29c3
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/684be01e7036580007c74d29
😎 Deploy Preview https://deploy-preview-10648--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: performance release: performance related release(mr only) labels Jun 12, 2025
@SyMind SyMind marked this pull request as ready for review June 12, 2025 07:27
@SyMind SyMind requested a review from jerrykingxyz as a code owner June 12, 2025 07:27
@codspeed-hq
Copy link

codspeed-hq bot commented Jun 12, 2025

CodSpeed Performance Report

Merging #10648 will not alter performance

Comparing perf-removed-files (fea29c3) with main (06b23af)

Summary

✅ 12 untouched benchmarks

@SyMind
Copy link
Member Author

SyMind commented Jun 12, 2025

@LingyuCoder seem errors.js in watch case not working right.

@SyMind SyMind merged commit 7c97b3d into main Jun 13, 2025
34 checks passed
@SyMind SyMind deleted the perf-removed-files branch June 13, 2025 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: performance release: performance related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants