Skip to content

feat: support passing error code to callbackify callbacks #10622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
h-a-n-a merged 1 commit into from
Jun 10, 2025
Merged

feat: support passing error code to callbackify callbacks #10622

h-a-n-a merged 1 commit into from
Jun 10, 2025

Conversation

@h-a-n-a
Copy link
Contributor

@h-a-n-a h-a-n-a commented Jun 10, 2025 •
edited
Loading

Summary

Support passing ErrorCode to callbackify callbacks.

Affected internal methods:

  1. compilation.rebuildModule
  2. compilation.addModule
  3. compilation.addEntry
  4. compilation.addInclude
  5. compiler.build
  6. compiler.rebuild

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link

netlify bot commented Jun 10, 2025 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit a5baad1
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/684814c71a8ec20008894e0e

@github-actions github-actions bot added release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack. labels Jun 10, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Jun 10, 2025

CodSpeed Performance Report

Merging #10622 will not alter performance

Comparing error-code-error (a5baad1) with main (7ab94f5)

🎉 Hooray! codspeed-node just leveled up to 4.0.1!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 12 untouched benchmarks

@h-a-n-a h-a-n-a enabled auto-merge (squash) June 10, 2025 11:51
@h-a-n-a h-a-n-a merged commit 918719f into main Jun 10, 2025
39 checks passed
@h-a-n-a h-a-n-a deleted the error-code-error branch June 10, 2025 11:52
stormslowly added a commit that referenced this pull request Jun 11, 2025
@stormslowly
Revert "feat: support passing error code to callbackify callbacks (#…
35ce642 
…10622)"

This reverts commit 918719f.
stormslowly added a commit that referenced this pull request Jun 11, 2025
@stormslowly
Revert "chore(deps): update napi to 3.0.0-beta.8" (#10633)
617ce5a 
* Revert "chore(deps): update napi to 3.0.0-beta.8 (#10562)"

This reverts commit 7ab94f5.

* Revert "feat: support passing error code to `callbackify` callbacks (#10622)"

This reverts commit 918719f.
@h-a-n-a h-a-n-a mentioned this pull request Jun 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chenjiahan chenjiahan chenjiahan approved these changes

Assignees

No one assigned

Labels

release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@h-a-n-a @chenjiahan