-
-
Notifications
You must be signed in to change notification settings - Fork 760
fix: Narrow the Dev Server Middleware type #10522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It will be convenient to have the Dev Server Middleware types exported from
the rspack. All our middleware is written in separate modules and annotated
with JSDoc types.
By exporting the type, we can ge rid of webpack-dev-server mentions in the
annotation and use `import('@rspack/core').DevServerMiddleware` to type
the middleware we have.
I have also made an effort to narrow the Middleware type so it is aligned
with the one in the webpack-dev-middleware.
(see https://github.com/webpack/webpack-dev-middleware/blob/master/types/index.d.ts#L370)
✅ Deploy Preview for rspack canceled.Built without sensitive environment variables
|
CodSpeed Performance ReportMerging #10522 will not alter performanceComparing Summary
|
Member
|
@LingyuCoder cc~ |
Member
|
@LingyuCoder Pin again.. |
LingyuCoder
approved these changes
Jun 10, 2025
Contributor
LingyuCoder
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
Contributor
Author
|
Thank you both! Appreciate your time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It will be convenient to have the Dev Server Middleware types exported from the rspack. All our middleware is written in separate modules and annotated with JSDoc types.
By exporting the type, we can ge rid of webpack-dev-server mentions in the annotation and use
import('@rspack/core').DevServerMiddlewareto type the middleware we have.I have also made an effort to narrow the Middleware type so it is aligned with the one in the webpack-dev-middleware.
(see https://github.com/webpack/webpack-dev-middleware/blob/master/types/index.d.ts#L370)
Example
Checklist