Skip to content

Conversation

@CPunisher
Copy link
Contributor

Summary

Related: #9895

This pr does two things:

  1. Remove wasi in the package.json, so the hacky code won't be rewritten.
  2. Prevent the handles in the workers from being active. See the details in the code.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link

netlify bot commented May 26, 2025

Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit d623e2f
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/683446e4537898000840fb50

@CPunisher CPunisher requested a review from h-a-n-a May 26, 2025 10:45
@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label May 26, 2025
@CPunisher CPunisher force-pushed the 05-26-fix/unref-worker branch from 7bab36a to e8153f1 Compare May 26, 2025 10:47
@codspeed-hq
Copy link

codspeed-hq bot commented May 26, 2025

CodSpeed Performance Report

Merging #10478 will not alter performance

Comparing CPunisher:05-26-fix/unref-worker (d623e2f) with main (3fa4a88)

🎉 Hooray! codspeed-node just leveled up to 4.0.1!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 11 untouched benchmarks

@CPunisher CPunisher merged commit a5098e5 into web-infra-dev:main May 26, 2025
35 checks passed
@CPunisher CPunisher deleted the 05-26-fix/unref-worker branch May 26, 2025 11:09
@CPunisher CPunisher mentioned this pull request Jun 26, 2025
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: bug fix release: bug related release(mr only)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants