Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes the 10x benchmark addon loader to correctly append the loader resourceQuery to relative module specifiers even when imports/exports span multiple lines or are side-effect-only imports.
Changes:
- Replace the single-line import/export matching regex with two specifier-based passes (
from '...'andimport '...') to support multiline and side-effect imports. - Add
appendQuery()helper to append the currentresourceQueryonly to relative specifiers and handle existing query strings.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ahabhgk
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
benchmark is broken in web-infra-dev/rspack#13002 cause
addons/10x/loader doesn't handle multi line import well(doesn't add resource query for multi line
The addons implementation is super hacky, we may need better ways