Skip to content

fix: fix break benchmark#81

Merged
hardfist merged 1 commit intomainfrom
fix-break-bench
Feb 10, 2026
Merged

fix: fix break benchmark#81
hardfist merged 1 commit intomainfrom
fix-break-bench

Conversation

@hardfist
Copy link
Copy Markdown
Contributor

@hardfist hardfist commented Feb 10, 2026

benchmark is broken in web-infra-dev/rspack#13002 cause
addons/10x/loader doesn't handle multi line import well(doesn't add resource query for multi line

import {
	MirroredRepeatWrapping,
	ClampToEdgeWrapping,
	RepeatWrapping,
	LinearEncoding,
	UnsignedByteType,
	RGBAFormat,
	LinearMipmapLinearFilter,
	LinearFilter,
	UVMapping
} from '../constants.js';

The addons implementation is super hacky, we may need better ways

Copilot AI review requested due to automatic review settings February 10, 2026 10:26
@hardfist hardfist changed the title chore: fix break benchmark fix: fix break benchmark Feb 10, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the 10x benchmark addon loader to correctly append the loader resourceQuery to relative module specifiers even when imports/exports span multiple lines or are side-effect-only imports.

Changes:

  • Replace the single-line import/export matching regex with two specifier-based passes (from '...' and import '...') to support multiline and side-effect imports.
  • Add appendQuery() helper to append the current resourceQuery only to relative specifiers and handle existing query strings.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@hardfist hardfist merged commit 609eb21 into main Feb 10, 2026
12 checks passed
@hardfist hardfist deleted the fix-break-bench branch February 10, 2026 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants