Skip to content

test: fix unstable build --watch test #858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Timeless0911 merged 2 commits into from
Mar 18, 2025
Merged

test: fix unstable build --watch test #858

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e0d81ee
test: fix unstable build --watch test
Timeless0911 Mar 18, 2025
29523c8
chore: update
Timeless0911 Mar 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions tests/integration/cli/build-watch/build.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,11 +58,12 @@ export default defineConfig({
describe('build --watch should handle add / change / unlink', async () => {
test('basic', async () => {
const tempSrcPath = path.join(__dirname, 'test-temp-src');
const tempConfigFile = path.join(__dirname, 'test-temp-rslib.config.mjs');
await fse.remove(tempSrcPath);
await fse.remove(path.join(__dirname, 'dist'));
await fse.copy(path.join(__dirname, 'src'), path.resolve(tempSrcPath));
const tempConfigFile = path.join(__dirname, 'test-temp-rslib.config.mjs');
await fse.remove(tempConfigFile);

await fse.copy(path.join(__dirname, 'src'), path.resolve(tempSrcPath));
fse.outputFileSync(
tempConfigFile,
`import { defineConfig } from '@rslib/core';
Expand Down Expand Up @@ -102,11 +103,11 @@ export default defineConfig({
shell: true,
},
);

await awaitFileExists(distIndexFile);

fse.outputFileSync(srcFooFile, `export const foo = 'foo';`);
fse.outputFileSync(srcFoo2File, `export const foo2 = 'foo2';`);
await awaitFileExists(distFooFile);
await awaitFileExists(distFoo2File);
const content1 = await fse.readFile(distFooFile, 'utf-8');
expect(content1!).toMatchInlineSnapshot(`
Expand All @@ -126,7 +127,7 @@ export default defineConfig({
fse.removeSync(srcIndexFile);

// change
const wait = await awaitFileChanges(distFooFile);
const wait = await awaitFileChanges(distFooFile, 'foo1');
fse.outputFileSync(srcFooFile, `export const foo = 'foo1';`);
await wait();
const content3 = await fse.readFile(distFooFile, 'utf-8');
Expand Down
7 changes: 5 additions & 2 deletions tests/scripts/helper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,13 +95,16 @@ export const awaitFileExists = async (dir: string) => {
}
};

export const awaitFileChanges = async (file: string) => {
export const awaitFileChanges = async (file: string, content: string) => {
const oldContent = await fse.readFile(file, 'utf-8');
return async () => {
const result = await waitFor(
() => {
try {
return fse.readFileSync(file, 'utf-8') !== oldContent;
return (
fse.readFileSync(file, 'utf-8') !== oldContent &&
fse.readFileSync(file, 'utf-8').includes(content)
);
} catch (e) {
return false;
}
Expand Down
Loading