Skip to content

fix(dts): error log of set declarationDir when dts.build is true #1120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 18, 2025
Merged

fix(dts): error log of set declarationDir when dts.build is true #1120

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cfff409
fix(dts): error log of set declarationDir when `dts.build` is true
Timeless0911 Jul 18, 2025
9d66c85
chore: update
Timeless0911 Jul 18, 2025
31d57fa
chore: update
Timeless0911 Jul 18, 2025
846ad9d
chore: update
Timeless0911 Jul 18, 2025
a00b46f
chore: update
Timeless0911 Jul 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion biome.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"$schema": "https://biomejs.dev/schemas/2.0.6/schema.json",
"$schema": "https://biomejs.dev/schemas/2.1.1/schema.json",
"assist": {
"actions": {
"source": {
Expand Down
6 changes: 1 addition & 5 deletions packages/plugin-dts/src/dts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,12 +167,8 @@ export async function generateDts(data: DtsGenOptions): Promise<void> {
(!rawCompilerOptions.declarationDir ||
normalize(rawCompilerOptions.declarationDir) !== resolvedDtsEmitPath)
) {
const info =
rawCompilerOptions.outDir && !rawCompilerOptions.declarationDir
? 'outDir'
: 'declarationDir';
throw Error(
`Please set ${info}: "${dtsEmitPath}" in ${color.underline(
`Please set "declarationDir": "${dtsEmitPath}" in ${color.underline(
tsconfigPath,
)} to keep it same as "dts.distPath" or "output.distPath.root" field in lib config.`,
);
Expand Down
8 changes: 4 additions & 4 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading