feat(deps): update @rspack/core to 2.0.0-beta.2#7172
Conversation
Summary of ChangesHello @chenjiahan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a crucial dependency upgrade, moving the project's core Rspack dependency to a newer beta version. This update ensures the project benefits from the latest improvements and fixes in Rspack, while also requiring corresponding adjustments to test snapshots and the package lock file to maintain consistency and stability across the codebase. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates @rspack/core from 2.0.0-beta.0 to 2.0.0-beta.2. The changes in package.json, pnpm-lock.yaml, and test snapshots are all consistent with this dependency bump. The snapshot updates correctly reflect changes in the ModuleFederationPlugin object, and the lockfile modifications are as expected for this version change. The update appears to be clean and correct.
There was a problem hiding this comment.
Pull request overview
This pull request updates the @rspack/core dependency from version 2.0.0-beta.0 to 2.0.0-beta.2, incorporating upstream changes from rspack and updating test snapshots to reflect the changes in the new version.
Changes:
- Updated @rspack/core from 2.0.0-beta.0 to 2.0.0-beta.2 in packages/core/package.json
- Updated all transitive dependency references in pnpm-lock.yaml
- Updated test snapshots to include the new
_treeShakingSharedPluginfield added to ModuleFederationPlugin by rspack
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/core/package.json | Updated @rspack/core version specifier from 2.0.0-beta.0 to 2.0.0-beta.2 |
| pnpm-lock.yaml | Updated all lock file entries for @rspack/core and related bindings from beta.0 to beta.2, including transitive dependencies |
| packages/core/tests/snapshots/moduleFederation.test.ts.snap | Added _treeShakingSharedPlugin: undefined field to ModuleFederationPlugin snapshots reflecting internal changes in rspack |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
Update @rspack/core to 2.0.0-beta.2 and update test snapshots.
Related Links
web-infra-dev/rspack#13041
Checklist