docs: update node version requirements for v2#7170
Conversation
Summary of ChangesHello @Timeless0911, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the quick-start documentation for Rsbuild v2 to reflect the latest recommended Node.js version requirements. The change ensures that users are guided towards stable and supported Long Term Support (LTS) versions, enhancing compatibility and providing a more reliable development environment. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the Node.js version requirements for Rsbuild v2 in the documentation. The changes are in both English and Chinese quick-start.mdx files. My review focuses on the correctness of the specified Node.js versions. I found that the versions mentioned (20.19.0 and 22.12.0) appear to be incorrect as they don't correspond to actual Node.js releases. I've suggested corrections to align the documentation with the engines field in package.json (>=20.10.0) for accuracy, while still keeping the recommendation for LTS versions.
Deploying rsbuild with
|
| Latest commit: |
e747d7e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e14ca913.rsbuild-v2.pages.dev |
| Branch Preview URL: | https://docs-update-node-version.rsbuild-v2.pages.dev |
There was a problem hiding this comment.
Pull request overview
Updates the Quick Start documentation to reflect Rsbuild v2’s recommended Node.js LTS version requirements.
Changes:
- Update English Quick Start to state Rsbuild v2 Node.js requirements as
>= 20.19.0or>= 22.12.0(LTS recommended). - Update Chinese Quick Start with the same Node.js requirement guidance.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| website/docs/en/guide/start/quick-start.mdx | Updates the Rsbuild v2 Node.js version requirement line in the Version requirements tip. |
| website/docs/zh/guide/start/quick-start.mdx | Updates the Rsbuild v2 Node.js version requirement line in the 版本要求 tip. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
Update Node.js version requirements for Rsbuild v2 (20.19+, 22.12+).
Related Links
None.
Checklist