chore: no need to enable asyncWebAssembly

[chenjiahan]

Summary

asyncWebAssembly has been enabled in Rspack 2.0 by default.

Related Links

web-infra-dev/rspack#12764

Checklist

• Tests updated (or not required).
• Documentation updated (or not required).

[gemini-code-assist]

Summary of Changes

Hello @chenjiahan, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the WebAssembly configuration within the core package by removing the explicit "asyncWebAssembly: true" setting. With Rspack 2.0 now enabling this experimental feature by default, the manual configuration is no longer necessary, leading to cleaner code and updated test snapshots that reflect this streamlined setup.

Highlights

• Configuration Simplification: Removed the explicit "asyncWebAssembly: true" setting from the WebAssembly plugin configuration.
• Default Behavior Update: This change is possible because "asyncWebAssembly" is now enabled by default in Rspack 2.0, making the explicit setting redundant.
• Test Snapshot Updates: Updated various test snapshots across "builder.test.ts.snap", "default.test.ts.snap", "environments.test.ts.snap", and "wasm.test.ts.snap" to reflect the removal of the "asyncWebAssembly" configuration.

Changelog

• packages/core/src/plugins/wasm.ts
  • Removed the explicit "asyncWebAssembly: true" configuration from the "experiments" object within the "pluginWasm" function.
• packages/core/tests/snapshots/builder.test.ts.snap
  • Updated the snapshot to remove the "experiments.asyncWebAssembly: true" entry.
• packages/core/tests/snapshots/default.test.ts.snap
  • Updated multiple snapshots to remove the "experiments.asyncWebAssembly: true" entry.
• packages/core/tests/snapshots/environments.test.ts.snap
  • Updated multiple snapshots to remove the "experiments.asyncWebAssembly: true" entry.
• packages/core/tests/snapshots/wasm.test.ts.snap
  • Updated the snapshot to remove the "experiments.asyncWebAssembly: true" entry.

Activity

• No human activity (comments, reviews, etc.) has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly removes the asyncWebAssembly experiment flag, which is now enabled by default in Rspack 2.0. The changes are clean, and the corresponding test snapshots have been updated accordingly. This is a good cleanup to remove unnecessary configuration. The changes look good to me.

[Copilot]

Pull request overview

Removes explicit enabling of experiments.asyncWebAssembly from Rsbuild’s wasm plugin and updates related test snapshots, aligning with Rspack 2.0 where asyncWebAssembly is enabled by default.

Changes:

• Stop setting experiments.asyncWebAssembly: true in pluginWasm.
• Update core test snapshots to reflect the absence of the experiments block.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
packages/core/src/plugins/wasm.ts	Removes redundant experiments.asyncWebAssembly config injection now that Rspack 2 defaults it on.
packages/core/tests/snapshots/wasm.test.ts.snap	Snapshot updated to no longer expect experiments.asyncWebAssembly.
packages/core/tests/snapshots/environments.test.ts.snap	Environment snapshots updated to remove the experiments.asyncWebAssembly section.
packages/core/tests/snapshots/default.test.ts.snap	Default config snapshots updated to remove the experiments.asyncWebAssembly section.
packages/core/tests/snapshots/builder.test.ts.snap	Builder snapshot updated to remove the experiments.asyncWebAssembly section.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.