chore: reduce duplicated parser merge calls

[chenjiahan]

Summary

Moved the typeReexportsPresence: 'tolerant' option to be merged together with other JavaScript parser settings, rather than in a separate merge call.

Checklist

• Tests updated (or not required).
• Documentation updated (or not required).

[gemini-code-assist]

Summary of Changes

Hello @chenjiahan, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the configuration logic for the JavaScript parser by consolidating two separate merge calls into a single, more efficient operation. This change streamlines the configuration process, reducing redundancy and improving code clarity within the pluginBasic function.

Highlights

• Consolidated Parser Configuration: The typeReexportsPresence: 'tolerant' option is now merged within an existing chain.module.parser.merge call for JavaScript settings, rather than in a separate call.
• Removed Redundant Merge Call: A separate, duplicate chain.module.parser.merge call that exclusively set typeReexportsPresence: 'tolerant' has been removed, streamlining the configuration.

Changelog

• packages/core/src/plugins/basic.ts
  • The typeReexportsPresence: 'tolerant' option has been moved into an existing chain.module.parser.merge call for JavaScript settings.
  • A redundant chain.module.parser.merge call, which previously only set typeReexportsPresence: 'tolerant', has been removed.

Activity

• No human activity (comments, reviews, approvals) has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request is a good refactoring that reduces duplicated code by merging two chain.module.parser.merge calls into one. My only suggestion is to preserve a comment that was removed, as it provides useful context. Moving it to a more specific location would improve code clarity.

[Copilot]

Pull request overview

Reduces duplication in the core “basic” plugin by consolidating JavaScript parser configuration into a single chain.module.parser.merge call.

Changes:

• Moved typeReexportsPresence: 'tolerant' into the existing JavaScript parser merge block.
• Removed the now-redundant second parser merge call.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.