feat: normalize shortcut input to handle whitespace and case

[chenjiahan]

Summary

Add helper function to trim and lowercase CLI shortcut input for better user experience. This makes shortcuts case-insensitive and tolerant to accidental whitespace.

Checklist

• Tests updated (or not required).
• Documentation updated (or not required).

[gemini-code-assist]

Summary of Changes

Hello @chenjiahan, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the robustness and user-friendliness of CLI shortcuts by implementing a normalization step for user input. It ensures that shortcuts are recognized consistently, regardless of casing or extraneous whitespace, thereby improving the overall interactive experience for developers.

Highlights

• New Helper Function: A new helper function, normalizeShortcutInput, has been introduced in packages/core/src/server/cliShortcuts.ts. This function is responsible for trimming whitespace and converting input to lowercase.
• Improved CLI Shortcut Handling: The CLI shortcut input processing now utilizes the normalizeShortcutInput function. This change makes CLI shortcuts case-insensitive and tolerant to accidental leading/trailing whitespace, enhancing user experience.
• New Test File: A new test file, packages/core/tests/cliShortcuts.test.ts, has been added to specifically test the functionality of the normalizeShortcutInput function, ensuring its correctness.

Changelog

• packages/core/src/server/cliShortcuts.ts
  • Added normalizeShortcutInput function to trim and lowercase input.
  • Integrated normalizeShortcutInput into the rl.on('line') event handler for CLI input.
• packages/core/tests/cliShortcuts.test.ts
  • New test file added to cover the normalizeShortcutInput function with various test cases.

Activity

• The author chenjiahan created this pull request to add a helper function for normalizing CLI shortcut input.
• The pull request description indicates that tests have been updated to cover the new functionality.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dea6561685

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[gemini-code-assist]

Code Review

This pull request introduces a helper function to normalize CLI shortcut inputs, making them case-insensitive and whitespace-tolerant, which is a good user experience improvement. My review includes two main points. First, a suggestion to use toLowerCase() instead of toLocaleLowerCase() for better robustness. Second, a high-severity issue is identified where custom shortcuts with uppercase keys will not work as expected, as the case-insensitivity is not fully implemented. Addressing these points will make the feature more robust and complete.

[Copilot]

Pull request overview

Adds normalization for CLI shortcut input so users can type shortcuts with surrounding whitespace and in any letter case, improving UX for interactive CLI usage.

Changes:

• Introduce normalizeShortcutInput() helper that trims and lowercases shortcut input.
• Apply normalization to readline’s line handler before matching shortcuts.
• Add unit tests covering whitespace and case normalization behavior.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
packages/core/src/server/cliShortcuts.ts	Adds and applies shortcut input normalization before shortcut matching.
packages/core/tests/cliShortcuts.test.ts	Adds tests validating trimming and case-insensitive shortcut normalization.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.