Skip to content

Conversation

@chenjiahan
Copy link
Member

Summary

Updated examples to include oneOf when modifying loaders in the JS rule.

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings January 26, 2026 02:32
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @chenjiahan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the clarity and accuracy of the bundlerChain configuration examples in the documentation. It ensures that users are guided to correctly apply the oneOf method when customizing JavaScript rule loaders, leading to more robust and understandable build configurations.

Highlights

  • Documentation Update: Updated bundlerChain examples in both English and Chinese documentation to explicitly include the .oneOf(CHAIN_ID.ONE_OF.JS_MAIN) method.
  • Loader Configuration Clarity: The examples now correctly demonstrate how to modify JavaScript rule loaders, covering scenarios like tapping into loader options, deleting loaders, and adding new loaders before or after existing ones.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly updates the bundlerChain examples in the documentation to use .oneOf() when modifying loaders under the JavaScript rule. This aligns the examples with recent changes to the internal webpack configuration structure.

My review includes a suggestion to also update the 'ID types' table in the documentation to include an explanation of CHAIN_ID.ONE_OF. This will help users understand this new part of the chain API that is being introduced in the examples.

@chenjiahan chenjiahan merged commit 83aed1d into main Jan 26, 2026
9 checks passed
@chenjiahan chenjiahan deleted the bunler_chain_examples_0126 branch January 26, 2026 02:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the documentation examples for bundlerChain configuration to reflect the breaking change introduced in PR #7032, where the built-in JS rule was converted to a oneOf structure. Users now need to use .oneOf(CHAIN_ID.ONE_OF.JS_MAIN) when modifying loaders in the JS rule.

Changes:

  • Updated all JS loader modification examples to include the oneOf chain call
  • Applied changes consistently to both English and Chinese documentation

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
website/docs/en/guide/configuration/rspack.mdx Updated 4 code examples to include .oneOf(CHAIN_ID.ONE_OF.JS_MAIN) when accessing JS rule loaders
website/docs/zh/guide/configuration/rspack.mdx Updated 4 code examples to include .oneOf(CHAIN_ID.ONE_OF.JS_MAIN) when accessing JS rule loaders (Chinese version)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant