-
-
Notifications
You must be signed in to change notification settings - Fork 249
docs: update bundlerChain examples to use oneOf #7045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @chenjiahan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the clarity and accuracy of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly updates the bundlerChain examples in the documentation to use .oneOf() when modifying loaders under the JavaScript rule. This aligns the examples with recent changes to the internal webpack configuration structure.
My review includes a suggestion to also update the 'ID types' table in the documentation to include an explanation of CHAIN_ID.ONE_OF. This will help users understand this new part of the chain API that is being introduced in the examples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the documentation examples for bundlerChain configuration to reflect the breaking change introduced in PR #7032, where the built-in JS rule was converted to a oneOf structure. Users now need to use .oneOf(CHAIN_ID.ONE_OF.JS_MAIN) when modifying loaders in the JS rule.
Changes:
- Updated all JS loader modification examples to include the
oneOfchain call - Applied changes consistently to both English and Chinese documentation
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| website/docs/en/guide/configuration/rspack.mdx | Updated 4 code examples to include .oneOf(CHAIN_ID.ONE_OF.JS_MAIN) when accessing JS rule loaders |
| website/docs/zh/guide/configuration/rspack.mdx | Updated 4 code examples to include .oneOf(CHAIN_ID.ONE_OF.JS_MAIN) when accessing JS rule loaders (Chinese version) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
Updated examples to include
oneOfwhen modifying loaders in the JS rule.Related Links
Checklist