-
-
Notifications
You must be signed in to change notification settings - Fork 249
docs: add guide to reflect CSS rule structure changes #7038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @chenjiahan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the upgrade guide from Rsbuild v1 to v2 by documenting significant changes to how CSS rules are structured. It introduces a detailed explanation of the new Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Deploying rsbuild with
|
| Latest commit: |
ce6ce54
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a9485887.rsbuild-v2.pages.dev |
| Branch Preview URL: | https://css-migration-0125.rsbuild-v2.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the v1-to-v2 upgrade guides to document the new oneOf-based CSS rule structure and clarify how to migrate custom loaders for both JS and CSS.
Changes:
- Clarified JS upgrade instructions to explicitly direct custom loaders from
CHAIN_ID.RULE.JSto theJS_MAINbranch. - Added a new section documenting the split of the built-in CSS rule into
CSS_MAIN,CSS_RAW, andCSS_INLINEoneOfbranches. - Provided concrete configuration diffs showing how to move custom CSS loaders and referenced equivalent changes for Less/Sass/Stylus plugin rules.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
website/docs/zh/guide/upgrade/v1-to-v2.mdx |
Updates the JS section wording and adds a new CSS section (in Chinese) explaining the oneOf branches and how to migrate custom loaders. |
website/docs/en/guide/upgrade/v1-to-v2.mdx |
Mirrors the JS wording clarification and adds the English CSS rule oneOf documentation and migration example. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ce6ce54c31
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the v1-to-v2 upgrade guide to document changes in the built-in JS and CSS rule structures. The update for the JS rule is clear and accurate. However, the new documentation for the CSS rule structure is inconsistent with the provided source code. The documentation describes a oneOf structure for CSS rules, but the implementation uses separate top-level rules. I've left critical comments on both the English and Chinese documentation files to highlight this discrepancy and suggest corrections to ensure the documentation is accurate.
Summary
Added a new section explaining that the built-in CSS rule is now split into three
oneOfbranches:CSS_MAIN,CSS_RAW, andCSS_INLINE, with instructions to move custom loaders to theCSS_MAINbranch.Related Links
Checklist