Skip to content

Conversation

@chenjiahan
Copy link
Member

Summary

Added a new section explaining that the built-in CSS rule is now split into three oneOf branches: CSS_MAIN, CSS_RAW, and CSS_INLINE, with instructions to move custom loaders to the CSS_MAIN branch.

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings January 25, 2026 11:35
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @chenjiahan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the upgrade guide from Rsbuild v1 to v2 by documenting significant changes to how CSS rules are structured. It introduces a detailed explanation of the new oneOf branching for CSS processing, including CSS_MAIN, CSS_RAW, and CSS_INLINE, and provides clear instructions for users to adapt their custom loader configurations to these new branches. This update is crucial for ensuring a smooth migration experience for developers.

Highlights

  • CSS Rule Structure Update: The built-in CSS rule is now split into three oneOf branches: CSS_MAIN for normal transforms, CSS_RAW for ?raw imports, and CSS_INLINE for ?inline imports.
  • Custom Loader Migration Guidance: Users who previously added loaders on CHAIN_ID.RULE.CSS should now move them to the CSS_MAIN branch, with an example provided in the documentation.
  • Plugin Consistency: Similar oneOf changes apply to the built-in rules in Less, Sass, and Stylus plugins, requiring corresponding updates for customizations.
  • JS Rule Documentation Refinement: A minor clarification was made in the JS rule documentation, specifying that custom JS loaders should be moved to the JS_MAIN branch.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@cloudflare-workers-and-pages
Copy link

Deploying rsbuild with  Cloudflare Pages  Cloudflare Pages

Latest commit: ce6ce54
Status: ✅  Deploy successful!
Preview URL: https://a9485887.rsbuild-v2.pages.dev
Branch Preview URL: https://css-migration-0125.rsbuild-v2.pages.dev

View logs

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the v1-to-v2 upgrade guides to document the new oneOf-based CSS rule structure and clarify how to migrate custom loaders for both JS and CSS.

Changes:

  • Clarified JS upgrade instructions to explicitly direct custom loaders from CHAIN_ID.RULE.JS to the JS_MAIN branch.
  • Added a new section documenting the split of the built-in CSS rule into CSS_MAIN, CSS_RAW, and CSS_INLINE oneOf branches.
  • Provided concrete configuration diffs showing how to move custom CSS loaders and referenced equivalent changes for Less/Sass/Stylus plugin rules.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
website/docs/zh/guide/upgrade/v1-to-v2.mdx Updates the JS section wording and adds a new CSS section (in Chinese) explaining the oneOf branches and how to migrate custom loaders.
website/docs/en/guide/upgrade/v1-to-v2.mdx Mirrors the JS wording clarification and adds the English CSS rule oneOf documentation and migration example.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ce6ce54c31

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the v1-to-v2 upgrade guide to document changes in the built-in JS and CSS rule structures. The update for the JS rule is clear and accurate. However, the new documentation for the CSS rule structure is inconsistent with the provided source code. The documentation describes a oneOf structure for CSS rules, but the implementation uses separate top-level rules. I've left critical comments on both the English and Chinese documentation files to highlight this discrepancy and suggest corrections to ensure the documentation is accurate.

@chenjiahan chenjiahan changed the title docs: add guid to reflect CSS rule structure changes docs: add guide to reflect CSS rule structure changes Jan 26, 2026
@chenjiahan chenjiahan merged commit 39ff6f9 into main Jan 26, 2026
14 checks passed
@chenjiahan chenjiahan deleted the css_migration_0125 branch January 26, 2026 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant