Skip to content

Conversation

@chenjiahan
Copy link
Member

Summary

Renamed CHAIN_ID.ONE_OF.JS_TRANSFORM to CHAIN_ID.ONE_OF.JS_MAIN, reflecting the new main JavaScript transform rule identifier.

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings January 25, 2026 09:43
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 25, 2026

Deploying rsbuild with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8e27750
Status: ✅  Deploy successful!
Preview URL: https://4e9c5d59.rsbuild-v2.pages.dev
Branch Preview URL: https://js-main-0125.rsbuild-v2.pages.dev

View logs

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @chenjiahan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors an internal identifier related to JavaScript transformation rules, renaming JS_TRANSFORM to JS_MAIN. This change aims to enhance the clarity and maintainability of the codebase by using a more intuitive name for the main JavaScript rule. The modifications are primarily confined to updating the constant definition and its usage across relevant plugins and documentation, ensuring a seamless transition for developers and users.

Highlights

  • Identifier Renaming: The constant CHAIN_ID.ONE_OF.JS_TRANSFORM has been renamed to CHAIN_ID.ONE_OF.JS_MAIN to provide a more accurate and descriptive identifier for the main JavaScript transform rule.
  • Codebase Updates: All internal references to the old identifier have been updated across core configuration files and various plugins, including plugin-babel, plugin-svelte, and plugin-svgr, ensuring consistency throughout the project.
  • Documentation Alignment: The upgrade documentation in both English and Chinese has been updated to reflect this naming change, guiding users on how to adapt their configurations.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3fd6427ea7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This PR correctly refactors CHAIN_ID.ONE_OF.JS_TRANSFORM to CHAIN_ID.ONE_OF.JS_MAIN. The changes are consistent across the updated files and documentation.

However, there is a critical issue: The file packages/core/src/plugins/swc.ts still references the old CHAIN_ID.ONE_OF.JS_TRANSFORM. Since this ID is removed, this will break the build. Please update this file to use CHAIN_ID.ONE_OF.JS_MAIN.

I've also added one suggestion to improve variable naming for consistency in packages/plugin-svgr/src/index.ts.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR renames the chain identifier constant from JS_TRANSFORM to JS_MAIN to better reflect its purpose as the main JavaScript transform rule. This follows up on PR #7032 which introduced the oneOf structure for JavaScript rules.

Changes:

  • Renamed the constant CHAIN_ID.ONE_OF.JS_TRANSFORM to CHAIN_ID.ONE_OF.JS_MAIN in the core configuration
  • Updated all plugin usages to reference the new constant name (babel, svelte, svgr)
  • Updated documentation in both English and Chinese upgrade guides

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/core/src/configChain.ts Renamed the constant definition from JS_TRANSFORM to JS_MAIN
packages/plugin-babel/src/plugin.ts Updated reference to use new constant name and renamed local variable
packages/plugin-babel/src/helper.ts Updated reference to use new constant name
packages/plugin-svelte/src/index.ts Updated reference to use new constant name and renamed local variable
packages/plugin-svgr/src/index.ts Updated reference to use new constant name and simplified code structure
website/docs/en/guide/upgrade/v1-to-v2.mdx Updated documentation examples to use new constant name
website/docs/zh/guide/upgrade/v1-to-v2.mdx Updated documentation examples to use new constant name

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@chenjiahan chenjiahan merged commit 82f2225 into main Jan 25, 2026
6 checks passed
@chenjiahan chenjiahan deleted the js_main_0125 branch January 25, 2026 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant