docs: update upgrade guide with built-in rule changes #7035
Conversation
Summary of ChangesHello @chenjiahan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the existing v1 to v2 upgrade documentation by introducing a new section that details significant changes to how built-in JavaScript and CSS transform rules are handled. It clarifies the adoption of Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Deploying rsbuild with
|
| Latest commit: |
2a192bc
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0b65ca65.rsbuild-v2.pages.dev |
| Branch Preview URL: | https://migration-builtin-rules-0125.rsbuild-v2.pages.dev |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the upgrade guide to include information about changes to built-in rules using oneOf. The changes are clear and provide a helpful example for JavaScript rule customization. I've added a few suggestions to improve the documentation's grammar and completeness, specifically regarding the mention of CSS rules without providing further details. Overall, this is a valuable addition to the migration guide.
There was a problem hiding this comment.
Pull request overview
This PR updates the Rsbuild v1 to v2 upgrade guide documentation to inform users about the built-in JS rule changes that now use oneOf branches. The documentation explains how to update custom loader configurations to work with the new structure.
Changes:
- Added "Built-in rule changes" section to both English and Chinese upgrade guides
- Documented the JS rule split into
JS_TRANSFORMandJS_RAWoneOf branches - Provided migration example for users who previously added loaders to
CHAIN_ID.RULE.JS
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| website/docs/en/guide/upgrade/v1-to-v2.mdx | Added English documentation for built-in JS rule oneOf structure changes with migration example |
| website/docs/zh/guide/upgrade/v1-to-v2.mdx | Added Chinese documentation for built-in JS rule oneOf structure changes with migration example |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1 participant
Summary
Added a section explaining that built-in JS and CSS transform rules now use
oneOfbranches, and instructions for updating custom loader configurationsRelated Links
Checklist