Skip to content

Comments

fix: update hmr import paths to include .js extension#6603

Merged
chenjiahan merged 1 commit intomainfrom
hmr_extesion_1118
Nov 18, 2025
Merged

fix: update hmr import paths to include .js extension#6603
chenjiahan merged 1 commit intomainfrom
hmr_extesion_1118

Conversation

@chenjiahan
Copy link
Member

Summary

Update the hmr import path to include .js extension as @rsbuild/core package includes the type: "module" field.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings November 18, 2025 08:14
@netlify
Copy link

netlify bot commented Nov 18, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 5c88d1c
🔍 Latest deploy log https://app.netlify.com/projects/rsbuild/deploys/691c2ae59b666f0008b8d10b
😎 Deploy Preview https://deploy-preview-6603--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 72 (🔴 down 4 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates import paths in the client code to include the .js extension for ES module compatibility, as required by the "type": "module" field in the package.json.

  • Updated import statement in overlay.ts to reference './hmr.js' instead of './hmr'
  • Updated externals configuration in rslib.config.ts to match the new import path

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/core/src/client/overlay.ts Updated import path to include .js extension for ES module compatibility
packages/core/rslib.config.ts Updated externals configuration to match the corrected import path with .js extension

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@chenjiahan chenjiahan merged commit adccef1 into main Nov 18, 2025
18 checks passed
@chenjiahan chenjiahan deleted the hmr_extesion_1118 branch November 18, 2025 08:22
@chenjiahan chenjiahan mentioned this pull request Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant