fix(entry): allow empty entry when module federation is used#6602
Merged
chenjiahan merged 3 commits intomainfrom Nov 18, 2025
Merged
fix(entry): allow empty entry when module federation is used#6602chenjiahan merged 3 commits intomainfrom
chenjiahan merged 3 commits intomainfrom
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a specific use case for Module Federation remote-only applications by allowing empty entry configurations when the ModuleFederationPlugin is detected. Previously, Rsbuild would throw an error if no entry module was found.
Key Changes:
- Modified entry validation logic to detect Module Federation plugin usage
- Added logic to set empty entry object when Module Federation is used without explicit entries
- Added e2e test case for Module Federation remote-only application
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
packages/core/src/plugins/entry.ts |
Enhanced entry validation to detect ModuleFederationPlugin and allow empty entry configuration when it's present |
e2e/cases/module-federation/v1-remote-only/src/Button.tsx |
Added test component to be exposed via Module Federation |
e2e/cases/module-federation/v1-remote-only/rsbuild.config.ts |
Added configuration for remote-only Module Federation test case |
e2e/cases/module-federation/v1-remote-only/moduleFederation.config.ts |
Added Module Federation configuration exposing the Button component |
e2e/cases/module-federation/v1-remote-only/index.test.ts |
Added e2e tests for dev and build modes of remote-only MF application |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Skip the empty entry validation when module federation plugin is detected. A MF app is allowed to expose remote modules without providing any entry module.
Related Links
Checklist