refactor: simplify build dependencies merging#6593
Merged
chenjiahan merged 2 commits intomainfrom Nov 17, 2025
Merged
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the build dependencies merging logic in the caching plugin, changing from a flexible multi-group approach to a simpler single-array approach. The refactoring reduces complexity but also changes the API surface.
Key Changes:
- Changed
getBuildDependenciesparameter fromuserBuildDependencies: Record<string, string[]>toadditionalDependencies?: string[] - Replaced object spreading with direct property assignment (
buildDependencies.additional = additionalDependencies) - Simplified the call site by passing
cacheConfig.buildDependenciesdirectly instead of wrapping it in an object
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Updates the build dependency handling logic in the caching plugin, simplifying how additional build dependencies are passed and stored.
Checklist