Skip to content

Comments

docs: align config JSDoc defaults with docs#6590

Merged
chenjiahan merged 2 commits intomainfrom
codex/update-jsdoc-for-rsbuild-config-options
Nov 16, 2025
Merged

docs: align config JSDoc defaults with docs#6590
chenjiahan merged 2 commits intomainfrom
codex/update-jsdoc-for-rsbuild-config-options

Conversation

@chenjiahan
Copy link
Member

Summary

  • align configuration JSDoc defaults such as security.sri and performance options with latest documentation
  • document default values for preload/prefetch resource hints and data URI limits

Testing

  • not run (not requested)

Codex Task

Copilot AI review requested due to automatic review settings November 16, 2025 08:14
@netlify
Copy link

netlify bot commented Nov 16, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit c3a2026
🔍 Latest deploy log https://app.netlify.com/projects/rsbuild/deploys/69198940cc4c8500087abe2b
😎 Deploy Preview https://deploy-preview-6590--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 60 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates JSDoc default value documentation in the configuration type definitions to better align with the actual codebase implementation and latest documentation.

  • Adds missing @default JSDoc tags for several performance and output configuration options
  • Updates the default value documentation for security.sri.enable
  • Documents specific default values for data URI size limits

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@chenjiahan chenjiahan merged commit e61a070 into main Nov 16, 2025
11 checks passed
@chenjiahan chenjiahan deleted the codex/update-jsdoc-for-rsbuild-config-options branch November 16, 2025 08:21
@chenjiahan chenjiahan mentioned this pull request Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant