Skip to content

perf: reduce redundant array allocations in asset regex builder #6581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chenjiahan merged 2 commits into from
Nov 15, 2025
Merged

perf: reduce redundant array allocations in asset regex builder #6581

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c2a9c94
perf: avoid duplicate mapping when building asset regex
chenjiahan Nov 15, 2025
436f7ee
Update packages/core/src/plugins/asset.ts
chenjiahan Nov 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions packages/core/src/plugins/asset.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,13 +70,17 @@ const chainStaticAssetRule = ({
};

export function getRegExpForExts(exts: string[]): RegExp {
const matcher = exts
.map((ext) => ext.trim())
.map((ext) => (ext.startsWith('.') ? ext.slice(1) : ext))
.join('|');
const normalizedExts: string[] = [];

for (const ext of exts) {
const trimmed = ext.trim();
normalizedExts.push(trimmed.startsWith('.') ? trimmed.slice(1) : trimmed);
}

const matcher = normalizedExts.join('|');

return new RegExp(
exts.length === 1 ? `\\.${matcher}$` : `\\.(?:${matcher})$`,
normalizedExts.length === 1 ? `\\.${matcher}$` : `\\.(?:${matcher})$`,
'i',
);
}
Expand Down
Loading