Merged
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables advanced ESM (ECMAScript Modules) support for @rsbuild/core by upgrading @rslib/core to version 0.17.2 and configuring three ESM build targets with the advancedEsm experimental feature.
- Updated
@rslib/coredependency from 0.17.1 to 0.17.2 across all packages - Enabled
experiments.advancedEsm: truefor ESM index, loaders, and client builds - Updated lock file with new dependency versions and cleaned up unused intermediate versions
Reviewed Changes
Copilot reviewed 17 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/core/rslib.config.ts | Added experiments.advancedEsm: true configuration to three ESM build targets (esm_index, esm_loaders, esm_client) |
| packages/core/package.json | Updated @rslib/core devDependency from 0.17.1 to 0.17.2 |
| scripts/config/package.json | Updated @rslib/core devDependency from 0.17.1 to 0.17.2 |
| scripts/test-helper/package.json | Updated @rslib/core devDependency from 0.17.1 to 0.17.2 |
| packages/plugin-vue/package.json | Updated @rslib/core devDependency from 0.17.1 to 0.17.2 |
| packages/plugin-svgr/package.json | Updated @rslib/core devDependency from 0.17.1 to 0.17.2 |
| packages/plugin-svelte/package.json | Updated @rslib/core devDependency from 0.17.1 to 0.17.2 |
| packages/plugin-stylus/package.json | Updated @rslib/core devDependency from 0.17.1 to 0.17.2 |
| packages/plugin-solid/package.json | Updated @rslib/core devDependency from 0.17.1 to 0.17.2 |
| packages/plugin-sass/package.json | Updated @rslib/core devDependency from 0.17.1 to 0.17.2 |
| packages/plugin-react/package.json | Updated @rslib/core devDependency from 0.17.1 to 0.17.2 |
| packages/plugin-preact/package.json | Updated @rslib/core devDependency from 0.17.1 to 0.17.2 |
| packages/plugin-less/package.json | Updated @rslib/core devDependency from 0.17.1 to 0.17.2 |
| packages/plugin-babel/package.json | Updated @rslib/core devDependency from 0.17.1 to 0.17.2 |
| packages/create-rsbuild/package.json | Updated @rslib/core devDependency from 0.17.1 to 0.17.2 |
| packages/compat/webpack/package.json | Updated @rslib/core devDependency from 0.17.1 to 0.17.2 |
| packages/compat/plugin-webpack-swc/package.json | Updated @rslib/core devDependency from 0.17.1 to 0.17.2 |
| pnpm-lock.yaml | Updated lock file with new dependency versions and resolutions, including @rslib/core@0.17.2, @rsbuild/core@1.6.6, rsbuild-plugin-dts@0.17.2, and cleaned up unused intermediate dependency versions |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
The same as #6513.
The
unexpected exportsissue has been fixed by Rspack, so we can enable advanced ESM for@rsbuild/corenow.Checklist