Skip to content

chore: update comments for pathinfo#6525

Merged
chenjiahan merged 1 commit intomainfrom
pathinfo_comments_1107
Nov 7, 2025
Merged

chore: update comments for pathinfo#6525
chenjiahan merged 1 commit intomainfrom
pathinfo_comments_1107

Conversation

@chenjiahan
Copy link
Member

Summary

Updated comment to clarify why pathinfo is disabled, referencing Rspack's moduleId behavior in development mode.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings November 7, 2025 07:27
@netlify
Copy link

netlify bot commented Nov 7, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 1ff7dc8
🔍 Latest deploy log https://app.netlify.com/projects/rsbuild/deploys/690d9f5fbf76ce00084cc07f
😎 Deploy Preview https://deploy-preview-6525--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 82 (🟢 up 22 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the comment explaining why pathinfo is disabled in the webpack/Rspack output configuration. The change clarifies that the reason is not primarily about performance, but rather because Rspack's moduleId already includes path information in development mode, making the additional path info redundant and reducing output cleanliness.

  • Updated comment to better reflect the actual reason for disabling pathinfo in Rspack

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@chenjiahan chenjiahan merged commit f2f941f into main Nov 7, 2025
18 checks passed
@chenjiahan chenjiahan deleted the pathinfo_comments_1107 branch November 7, 2025 07:34
@chenjiahan chenjiahan mentioned this pull request Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments