Skip to content

Comments

Revert "build(core): enable advanced ESM (#6513)"#6524

Merged
chenjiahan merged 1 commit intomainfrom
revert_esm_core_1107
Nov 7, 2025
Merged

Revert "build(core): enable advanced ESM (#6513)"#6524
chenjiahan merged 1 commit intomainfrom
revert_esm_core_1107

Conversation

@chenjiahan
Copy link
Member

Summary

This reverts PR #6513 because the advancedEsm introduced some unexpected exports:

Screenshot 2025-11-07 at 08 06 41

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings November 7, 2025 00:09
@netlify
Copy link

netlify bot commented Nov 7, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit a5594e8
🔍 Latest deploy log https://app.netlify.com/projects/rsbuild/deploys/690d38da1cd3fe00080b248a
😎 Deploy Preview https://deploy-preview-6524--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 54 (🔴 down 26 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the experimental advancedEsm configuration from three ESM format build configurations in the core package's rslib config file. The change simplifies the build configuration by removing this experimental feature flag.

  • Removes experiments.advancedEsm: true from esm_index, esm_loaders, and esm_client configurations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@chenjiahan chenjiahan merged commit 7aee863 into main Nov 7, 2025
18 checks passed
@chenjiahan chenjiahan deleted the revert_esm_core_1107 branch November 7, 2025 02:52
@chenjiahan chenjiahan mentioned this pull request Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant