Skip to content

Comments

ci: use unified Rstack ecosystem CI#6517

Merged
chenjiahan merged 1 commit intoweb-infra-dev:mainfrom
fi3ework:eco
Nov 6, 2025
Merged

ci: use unified Rstack ecosystem CI#6517
chenjiahan merged 1 commit intoweb-infra-dev:mainfrom
fi3ework:eco

Conversation

@fi3ework
Copy link
Member

@fi3ework fi3ework commented Nov 6, 2025

Summary

to use the unified ecosystem CI https://rstack-ecosystem-ci.netlify.app/?stack=rsbuild.

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings November 6, 2025 08:42
@netlify
Copy link

netlify bot commented Nov 6, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 1ba05d3
🔍 Latest deploy log https://app.netlify.com/projects/rsbuild/deploys/690c820f4bd2430007fc43eb
😎 Deploy Preview https://deploy-preview-6517--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 57 (🔴 down 13 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the Ecosystem CI workflow to use reusable composite actions from the rspack-contrib/rstack-ecosystem-ci repository, significantly simplifying the workflow configuration.

  • Replaced two complex workflow jobs with simpler job definitions that use external composite actions
  • Removed the local custom action .github/actions/eco-ci-result
  • Updated to use a new GitHub token secret (REPO_RSBUILD_ECO_CI_GITHUB_TOKEN_NEXT)

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/ecosystem-ci.yml Simplified workflow by replacing inline GitHub script actions and manual comment handling with two external composite actions (ecosystem_ci_dispatch and ecosystem_ci_per_commit)
.github/actions/eco-ci-result/action.yml Deleted custom action that formatted ecosystem CI results, as this functionality is now handled by the external composite actions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

continue-on-error: true
uses: convictional/trigger-workflow-and-wait@f69fa9eedd3c62a599220f4d5745230e237904be # v1.6.5
- name: Trigger Ecosystem CI
uses: rspack-contrib/rstack-ecosystem-ci/.github/actions/ecosystem_ci_dispatch@main
Copy link

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using @main as the action reference creates a moving target that can break the workflow without warning. Consider pinning to a specific commit SHA or version tag for stability and reproducibility.

Copilot uses AI. Check for mistakes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fi3ework Could we pin to a release tag and let renovate to upgrade it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @yifancong it suddenly occurred to me https://github.com/web-infra-dev/rsdoctor-action also need to tag and release a version in the future as well. 🤣

Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@chenjiahan chenjiahan merged commit 7897e05 into web-infra-dev:main Nov 6, 2025
11 checks passed
@chenjiahan chenjiahan mentioned this pull request Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants