Merged
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables the advancedEsm experimental feature for ESM format configurations across multiple packages in the monorepo. The feature is enabled for all ESM-based builds to take advantage of advanced ESM handling capabilities.
- Enabled
experiments.advancedEsm: truefor ESM configurations - Updated the shared base configuration in
scripts/config/rslib.config.ts - Applied the setting to individual packages that define custom ESM configurations
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| scripts/config/rslib.config.ts | Adds advancedEsm experiment to the base esmConfig used across packages |
| packages/plugin-svgr/rslib.config.ts | Enables advancedEsm for the custom ESM loader configuration |
| packages/create-rsbuild/rslib.config.ts | Adds advancedEsm experiment to the standalone ESM build configuration |
| packages/compat/plugin-webpack-swc/rslib.config.ts | Enables advancedEsm for the custom ESM loader configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enable Rslib's advanced ESM features for all plugin packages.
Before
@rsbuild/webpack:File (esm) Size dist/0~502.js 10.9 kB dist/index.js 15.7 kB dist/0~0.js 73.9 kB Total: 100.4 kBAfter
@rsbuild/webpack:File (esm) Size dist/rslib-runtime.js 1.3 kB dist/index.js 12.4 kB dist/0~24.js 82.8 kB Total: 96.6 kBRelated Links
Checklist