refactor: use Rspack's OutputFileSystem type directly#6512
Merged
chenjiahan merged 2 commits intomainfrom Nov 6, 2025
Merged
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors type handling for OutputFileSystem by removing a custom type extension and using the native @rspack/core type directly. The custom OutputFileSystem type that extended Rspack.OutputFileSystem with an optional createReadStream method has been removed, and all references now use Rspack.OutputFileSystem from the rspack types.
- Removed custom
OutputFileSystemtype definition that extendedRspack.OutputFileSystem - Updated all import statements to use
Rspack.OutputFileSysteminstead of the local type - Modified
setupOutputFileSystemto return the native fs module as a fallback when no compiler has an output filesystem
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/core/src/server/assets-middleware/index.ts | Removed custom OutputFileSystem type definition |
| packages/core/src/server/assets-middleware/setupOutputFileSystem.ts | Changed return type to use @rspack/core OutputFileSystem and updated fallback to return native fs module |
| packages/core/src/server/assets-middleware/middleware.ts | Updated parameter types to use Rspack.OutputFileSystem instead of local type |
| packages/core/src/server/assets-middleware/getFileFromUrl.ts | Updated parameter types to use Rspack.OutputFileSystem instead of local type |
| packages/core/src/server/browserLogs.ts | Removed unused import and updated type cast to use Rspack.OutputFileSystem |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove custom
OutputFileSystemtype definition and use Rspack's built-in type instead.This simplifies the codebase by relying on the official type definitions provided by Rspack.
Related Links
Checklist