refactor: replace any type with unknown in type definitions#6509
Merged
chenjiahan merged 1 commit intomainfrom Nov 5, 2025
Merged
refactor: replace any type with unknown in type definitions#6509chenjiahan merged 1 commit intomainfrom
chenjiahan merged 1 commit intomainfrom
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves type safety by replacing the use of any with unknown types across multiple plugin packages and test helper code. This change enforces stricter type checking and prevents unintentional type bypasses.
- Replaced
Record<string, any>withRecord<string, unknown>in type guards and interface definitions - Updated function parameter types from
any[]tounknown[]for better type safety - Added explicit type definition for
ResolveUrlJoinItemin the Sass plugin helper
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/plugin-vue/src/splitChunks.ts | Updated isPlainObject type guard return type from any to unknown |
| packages/plugin-svelte/src/index.ts | Changed index signature types in SvelteLoaderOptions from any to unknown |
| packages/plugin-sass/src/helpers.ts | Updated callback parameter types and added explicit ResolveUrlJoinItem type |
| packages/plugin-react/src/splitChunks.ts | Updated isPlainObject type guard return type from any to unknown |
| packages/plugin-less/src/index.ts | Updated isPlainObject return type from any to unknown |
| e2e/helper/logs.ts | Changed console method parameter type from any[] to unknown[] |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace usage of
anytype withunknownin various type definitions across multiple plugins to improve type safety and maintainability.Checklist