Skip to content

refactor(core): optimize config merging and object checks#6497

Merged
chenjiahan merged 3 commits intomainfrom
optimize_merge_1104
Nov 4, 2025
Merged

refactor(core): optimize config merging and object checks#6497
chenjiahan merged 3 commits intomainfrom
optimize_merge_1104

Conversation

@chenjiahan
Copy link
Member

Summary

  • Extract getProto for better performance in isPlainObject
  • Replace array with Set for OVERRIDE_PATHS for faster lookups
  • Simplify array merging logic in merge function

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings November 4, 2025 06:51
@netlify
Copy link

netlify bot commented Nov 4, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 0ccd25e
🔍 Latest deploy log https://app.netlify.com/projects/rsbuild/deploys/6909a25a9222ef0008dd008b
😎 Deploy Preview https://deploy-preview-6497--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 70 (🔴 down 3 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@netlify
Copy link

netlify bot commented Nov 4, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit c304b35
🔍 Latest deploy log https://app.netlify.com/projects/rsbuild/deploys/6909a5168d6e1e0008f5c751
😎 Deploy Preview https://deploy-preview-6497--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 64 (🔴 down 9 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chenjiahan chenjiahan merged commit 59688cd into main Nov 4, 2025
11 checks passed
@chenjiahan chenjiahan deleted the optimize_merge_1104 branch November 4, 2025 07:12
@chenjiahan chenjiahan mentioned this pull request Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant