fix(mergeConfig): avoiding adding undefined properties#6496
Merged
chenjiahan merged 1 commit intomainfrom Nov 4, 2025
Merged
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the normalizeConfigStructure function where config properties could be lost during normalization. The refactor ensures all original config properties are preserved by creating a shallow copy upfront and only overwriting normalized properties when they exist.
- Replaced destructuring with rest operator (
...rest) with a full shallow copy of the config - Changed from conditionally normalizing properties inline to explicitly assigning them back to the config copy
- Fixed the return statement to return the complete normalized config instead of reconstructing it
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Avoiding adding undefined
devoroutputproperties when calling themergeRsbuildConfigmethod.Checklist