test(e2e): add tests to verify env mode command handling#6477
Merged
chenjiahan merged 2 commits intomainfrom Oct 31, 2025
Merged
test(e2e): add tests to verify env mode command handling#6477chenjiahan merged 2 commits intomainfrom
chenjiahan merged 2 commits intomainfrom
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the function-based config feature to test the envMode parameter and updates the vanilla example to demonstrate config function usage. The changes add support for testing the envMode parameter alongside env and command in the defineConfig callback.
Key Changes
- Added
envModeparameter support to the function config test case - Updated tests to verify proper values for
env,envMode, andcommandparameters - Updated vanilla example to demonstrate function-based config with environment checks
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| examples/vanilla/rsbuild.config.ts | Changed from empty config to function-based config with environment logging |
| e2e/cases/cli/function-config/src/index.js | Changed console output from static string to DEFINED_VALUE placeholder |
| e2e/cases/cli/function-config/rsbuild.config.ts | Added envMode parameter and replaced output config with source.define config |
| e2e/cases/cli/function-config/index.test.ts | Restructured tests to use single distDir, added envMode test cases, and updated assertions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added new e2e tests to verify that builds correctly reflect different environment variables (
NODE_ENV) and environment modes (env-mode) in the configuration function.Related Links
config.envwhen using--env-mode developmentcommand on Linux #6475Checklist