test(e2e): add test cases for JSON tree shaking#6476
Merged
chenjiahan merged 1 commit intomainfrom Oct 31, 2025
Merged
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the JSON import test structure by removing the generic import-json test case and replacing it with three more specific test cases that separately validate different JSON import patterns and tree-shaking behavior.
- Removed the old
import-jsontest case that tested both named and default imports together - Added three new focused test cases:
import-json-named,import-json-default, andimport-json-attributes - Each new test validates that tree-shaking correctly removes unused JSON properties from the bundle
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| e2e/cases/assets/import-json/src/index.js | Removed as part of old test deletion |
| e2e/cases/assets/import-json/src/a.json | Removed as part of old test deletion |
| e2e/cases/assets/import-json/src/b.json | Removed as part of old test deletion |
| e2e/cases/assets/import-json/index.test.ts | Removed old test that combined multiple import styles |
| e2e/cases/assets/import-json-named/src/index.js | Added to test named imports from JSON with tree-shaking |
| e2e/cases/assets/import-json-named/src/data.json | Added test data for named import test |
| e2e/cases/assets/import-json-named/index.test.ts | Added test validating named JSON imports and tree-shaking |
| e2e/cases/assets/import-json-default/src/index.js | Added to test default imports from JSON with tree-shaking |
| e2e/cases/assets/import-json-default/src/data.json | Added test data for default import test |
| e2e/cases/assets/import-json-default/index.test.ts | Added test validating default JSON imports and tree-shaking |
| e2e/cases/assets/import-json-attributes/src/index.js | Added to test JSON imports with import attributes syntax |
| e2e/cases/assets/import-json-attributes/src/data.json | Added test data for import attributes test |
| e2e/cases/assets/import-json-attributes/index.test.ts | Added test validating JSON imports with import attributes and tree-shaking |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add test cases for JSON named imports, default imports and import attributes and validate the tree shaking result.
Checklist