chore: simplify source map template to string literal#6472
Merged
chenjiahan merged 1 commit intomainfrom Oct 31, 2025
Merged
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the devtoolModuleFilenameTemplate configuration from a function to a string template literal. The change simplifies the code by using webpack/rspack's built-in template string [absolute-resource-path] instead of a custom function that returned absoluteResourcePath.
- Replaced function-based template with string literal template
[absolute-resource-path] - Updated constant naming from
sourceMapFilenameTemplatetoDEFAULT_SOURCE_MAP_TEMPLATE - Updated all test snapshots to reflect the new string template format
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/core/src/plugins/sourceMap.ts | Refactored source map template from function to string literal |
| packages/core/tests/snapshots/environments.test.ts.snap | Updated snapshot to show string template instead of [Function] |
| packages/core/tests/snapshots/default.test.ts.snap | Updated snapshot to show string template instead of [Function] |
| packages/core/tests/snapshots/builder.test.ts.snap | Updated snapshot to show string template instead of [Function] |
| packages/compat/webpack/tests/snapshots/default.test.ts.snap | Updated snapshot to show string template instead of [Function] |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Replace the
devtoolModuleFilenameTemplatefunction with a string literal[absolute-resource-path]to simplify the config.Related Links
Checklist