fix(ssr): correct inspect offset when loading bundles#6464
Merged
chenjiahan merged 2 commits intomainfrom Oct 30, 2025
Merged
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves source mapping accuracy for CommonJS module execution by adjusting code wrapping and adding column offset configuration. It also makes the e2e test environment more flexible for debugging scenarios.
- Modified code generation in CommonJsRunner to split code definition for better source mapping
- Added
columnOffsettovm.runInThisContextto correct stack traces - Made e2e test configuration conditional based on debugger presence and environment variables
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/core/src/server/runner/cjs.ts | Refactored code wrapping to extract function definition and added columnOffset for accurate source mapping |
| e2e/cases/server/ssr/rsbuild.config.ts | Added inspector-based writeToDisk configuration and made module output conditional on TEST_ESM_LIBRARY |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
chenjiahan
reviewed
Oct 30, 2025
chenjiahan
approved these changes
Oct 30, 2025
chenjiahan
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix ssr loadBundle inspect offset.
expect inspect
console.log('load SSR'), but offset:before:
after:
Related Links
Checklist