feat: support JSON imports with raw query#6438
Merged
chenjiahan merged 1 commit intomainfrom Oct 26, 2025
Merged
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for importing JSON files with the ?raw query parameter, allowing developers to load JSON content as raw text strings instead of parsed objects. This addresses issue #6426 by implementing a new rule in the asset plugin to handle these imports.
Key Changes:
- Added a JSON rule in the asset plugin to process
?rawquery imports asasset/sourcetype - Added the
JSONrule identifier to theCHAIN_IDconstants - Created comprehensive E2E tests to verify raw JSON imports work correctly
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/core/src/plugins/asset.ts | Implements JSON raw query handling logic with new rule and updated comment |
| packages/core/src/configChain.ts | Adds JSON constant to CHAIN_ID for rule identification |
| e2e/cases/assets/import-json-raw-query/* | Adds test files and assertions for raw JSON import functionality |
| packages/core/tests/snapshots/* | Updates snapshots to reflect new JSON rule in bundler configurations |
| packages/compat/webpack/tests/snapshots/* | Updates webpack compatibility snapshots with new JSON rule |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"foo.json?raw")Related Links
?rawsuffix as raw strings #6426Checklist