fix(browser-logs): simplify file paths for full stack trace#6434
Merged
chenjiahan merged 1 commit intomainfrom Oct 26, 2025
Merged
fix(browser-logs): simplify file paths for full stack trace#6434chenjiahan merged 1 commit intomainfrom
chenjiahan merged 1 commit intomainfrom
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies the format of file paths in browser error stack traces by removing redundant path information when the method name would be a file path.
- Extracts duplicate logic into a reusable
isValidMethodNamehelper function - Updates stack trace formatting to exclude file paths from the method name position
- Updates test expectations to reflect the simplified format
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/core/src/server/browserLogs.ts | Adds isValidMethodName helper to detect and filter out file paths from method names, replacing duplicate validation logic |
| e2e/cases/browser-logs/stack-trace-full/index.test.ts | Updates expected stack trace format to reflect simplified output without duplicate file path in method name position |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Simplify file paths when printing browser logs with full stack trace:
Checklist