feat(browser-logs): add method name to error stack summary#6433
Merged
chenjiahan merged 2 commits intomainfrom Oct 25, 2025
Merged
feat(browser-logs): add method name to error stack summary#6433chenjiahan merged 2 commits intomainfrom
chenjiahan merged 2 commits intomainfrom
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances error logging by adding method names to error stack summaries, providing better context about where errors occur. The change updates both the logging implementation and the corresponding documentation examples.
Key Changes:
- Modified error log formatting to include method names (e.g.,
at handleClick) before file locations - Added filtering to exclude unhelpful method names like
<unknown>or file paths - Updated return type of
resolveOriginalLocationto include both frame and location information
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/core/src/server/browserLogs.ts | Core implementation changes for adding method names to error summaries and updating type definitions |
| website/docs/en/config/dev/browser-logs.mdx | English documentation update showing the new error format with method names |
| website/docs/zh/config/dev/browser-logs.mdx | Chinese documentation update showing the new error format with method names |
| e2e/cases/browser-logs/react-error/index.test.ts | Updated test expectations for React error logs to include method names |
| e2e/cases/browser-logs/vue-error/index.test.ts | Updated test expectations for Vue error logs to include method names |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Add method name to error logs when available and improve the formatting of stack traces. This provides more context about where errors occur in the code.
Checklist