-
-
Notifications
You must be signed in to change notification settings - Fork 272
feat: add full stack trace option for browser logs #6427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
14 changes: 14 additions & 0 deletions
14
e2e/cases/browser-logs/stack-trace-full-react-error/index.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| import { rspackTest } from '@e2e/helper'; | ||
|
|
||
| // Omitted some parts of the stack trace as they are not static | ||
| const EXPECTED_LOG = `error [browser] Uncaught ReferenceError: undefinedValue is not defined | ||
| at App (src/App.jsx:4:0) | ||
| at Object.react_stack_bottom_frame (../../../../node_modules/.pnpm/react-dom`; | ||
|
|
||
| rspackTest( | ||
| 'should display formatted full stack trace in React component', | ||
| async ({ dev }) => { | ||
| const rsbuild = await dev(); | ||
| await rsbuild.expectLog(EXPECTED_LOG, { posix: true }); | ||
| }, | ||
| ); |
11 changes: 11 additions & 0 deletions
11
e2e/cases/browser-logs/stack-trace-full-react-error/rsbuild.config.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| import { defineConfig } from '@rsbuild/core'; | ||
| import { pluginReact } from '@rsbuild/plugin-react'; | ||
|
|
||
| export default defineConfig({ | ||
| plugins: [pluginReact()], | ||
| dev: { | ||
| browserLogs: { | ||
| stackTrace: 'full', | ||
| }, | ||
| }, | ||
| }); |
9 changes: 9 additions & 0 deletions
9
e2e/cases/browser-logs/stack-trace-full-react-error/src/App.jsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| const App = () => { | ||
| return ( | ||
| <button id="button" type="button"> | ||
| count: {undefinedValue} | ||
| </button> | ||
| ); | ||
| }; | ||
|
|
||
| export default App; |
9 changes: 9 additions & 0 deletions
9
e2e/cases/browser-logs/stack-trace-full-react-error/src/index.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| import React from 'react'; | ||
| import { createRoot } from 'react-dom/client'; | ||
| import App from './App'; | ||
|
|
||
| const container = document.getElementById('root'); | ||
| if (container) { | ||
| const root = createRoot(container); | ||
| root.render(React.createElement(App)); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| import { rspackTest } from '@e2e/helper'; | ||
|
|
||
| // Omitted some parts of the stack trace as they are not static | ||
| const EXPECTED_LOG = `error [browser] Uncaught Error: foo | ||
| at foo (src/foo.js:2:0) | ||
| at ./src/index.js (src/index.js:3:0) | ||
| at __webpack_require__ (http://localhost`; | ||
|
|
||
| rspackTest('should display formatted full stack trace', async ({ dev }) => { | ||
| const rsbuild = await dev(); | ||
| await rsbuild.expectLog(EXPECTED_LOG, { posix: true }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| import { defineConfig } from '@rsbuild/core'; | ||
|
|
||
| export default defineConfig({ | ||
| dev: { | ||
| browserLogs: { | ||
| stackTrace: 'full', | ||
| }, | ||
| }, | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| export function foo() { | ||
| throw new Error('foo'); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| import { foo } from './foo'; | ||
|
|
||
| foo(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.