Skip to content

ci: disable package manager cache in GitHub workflows#6424

Merged
chenjiahan merged 1 commit intomainfrom
disable_ci_cache_1024
Oct 24, 2025
Merged

ci: disable package manager cache in GitHub workflows#6424
chenjiahan merged 1 commit intomainfrom
disable_ci_cache_1024

Conversation

@chenjiahan
Copy link
Member

Summary

Although the Rsbuild repository uses pnpm, actions/setup-node automatically enables caching (see https://github.com/web-infra-dev/rsbuild/actions/runs/18767609069/job/53545564346?pr=6423), which is inconsistent with its documentation.

This PR explicitly disables caching to avoid this issue.

Related Links

https://github.com/actions/setup-node?tab=readme-ov-file#breaking-changes-in-v6

image

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings October 24, 2025 02:37
@netlify
Copy link

netlify bot commented Oct 24, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 124ff10
🔍 Latest deploy log https://app.netlify.com/projects/rsbuild/deploys/68fae6570e7927000834e722
😎 Deploy Preview https://deploy-preview-6424--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 69 (🟢 up 1 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR disables automatic package manager caching in GitHub Actions workflows to address inconsistent behavior introduced in actions/setup-node v6.0.0, where caching is unexpectedly enabled by default despite documentation suggesting otherwise.

Key Changes:

  • Added explicit package-manager-cache: false configuration to all actions/setup-node steps across workflow files

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
.github/workflows/test.yml Disabled package manager cache in three separate test jobs
.github/workflows/release.yml Disabled package manager cache in the release job
.github/workflows/lint.yml Disabled package manager cache in the lint job
.github/workflows/ecosystem-ci.yml Disabled package manager cache in the ecosystem CI job

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@chenjiahan chenjiahan merged commit 554eda6 into main Oct 24, 2025
12 checks passed
@chenjiahan chenjiahan deleted the disable_ci_cache_1024 branch October 24, 2025 02:48
@chenjiahan chenjiahan mentioned this pull request Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant