fix: apply LiteralUnion to more types for better type safety#6419
Merged
chenjiahan merged 1 commit intomainfrom Oct 24, 2025
Merged
fix: apply LiteralUnion to more types for better type safety#6419chenjiahan merged 1 commit intomainfrom
chenjiahan merged 1 commit intomainfrom
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances type safety by applying the LiteralUnion utility type to several type definitions that previously used plain string types. This allows for better IDE autocomplete suggestions while still accepting any string value.
Key changes:
- Updated
AppIconItem.purposeto useLiteralUnionwith specific icon purpose values - Updated
CSSLoaderOptions.modulesto useLiteralUnionwith CSS module types - Updated
StyleLoaderOptions.insertto useLiteralUnionwith DOM insertion points
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/core/src/types/config.ts | Updated AppIconItem.purpose type to use LiteralUnion with standard icon purposes |
| packages/core/src/types/thirdParty.ts | Added LiteralUnion import and applied it to CSSLoaderOptions.modules and StyleLoaderOptions.insert |
| website/docs/en/config/html/app-icon.mdx | Updated documentation to reflect the new type signature for purpose property |
| website/docs/zh/config/html/app-icon.mdx | Updated Chinese documentation to reflect the new type signature for purpose property |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Updates some type definitions to use the
LiteralUniontype for better type safety.Checklist