fix(types): add LiteralUnion type and apply to assetPrefix#6416
Merged
chenjiahan merged 1 commit intomainfrom Oct 23, 2025
Merged
fix(types): add LiteralUnion type and apply to assetPrefix#6416chenjiahan merged 1 commit intomainfrom
chenjiahan merged 1 commit intomainfrom
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a LiteralUnion utility type to improve TypeScript autocomplete for string literal unions while still accepting any string. The type is applied to the assetPrefix configuration property to provide better developer experience when using the 'auto' literal while maintaining type flexibility.
Key changes:
- Added
LiteralUnion<T extends U, U>utility type to enable autocomplete for specific string literals without restricting the type to only those literals - Updated
OutputConfig.assetPrefixto useLiteralUnion<'auto', string>instead ofstring | 'auto' - Updated
DevConfig.assetPrefixto useLiteralUnion<'auto', string> | booleanfor consistency
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/core/src/types/utils.ts | Adds the LiteralUnion utility type with reference to TypeScript issue |
| packages/core/src/types/config.ts | Imports LiteralUnion and applies it to both OutputConfig.assetPrefix and DevConfig.assetPrefix properties |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
davide97g
approved these changes
Oct 23, 2025
andreamazzatxt
approved these changes
Oct 23, 2025
Member
Author
|
Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
assetPrefixto improve type safety.Related Links
Checklist