Merged
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes performance by directly accessing compilation.assets instead of calling stats.toJson({ assets: true }) to retrieve asset information, significantly reducing the time needed to gather stats data.
Key Changes:
- Introduced a lightweight
RsbuildAssettype containing onlynameandsizeproperties - Modified
getAssetsFromStats()to extract assets directly fromcompilation.assets - Removed
assetsfromRsbuildStatsItemtype and eliminated unnecessary stats options configuration
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/core/src/helpers/stats.ts | Introduced RsbuildAsset type and refactored getAssetsFromStats() to access compilation.assets directly; removed build-specific stats options |
| packages/core/src/types/rsbuild.ts | Removed 'assets' from RsbuildStatsItem type definition |
| packages/core/src/types/config.ts | Replaced PrintFileSizeAsset type definition with reference to RsbuildAsset |
| packages/core/src/plugins/fileSize.ts | Updated to use Rspack.Stats instead of RsbuildStatsItem; refactored to work with new RsbuildAsset type |
| packages/core/src/server/middlewares.ts | Removed optional chaining operators for asset properties |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
As Rsbuild only needs the name and size of the assets from the Rspack stats object, using
compilation.assetsis much faster than using thestats.toJson({ assets: true }).Before
After
Checklist