Skip to content

fix(dev-server): improve error page display #6412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chenjiahan merged 3 commits into from
Oct 23, 2025
Merged

fix(dev-server): improve error page display #6412

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
969b9d2
fix(dev-server): improve error page display
chenjiahan Oct 23, 2025
f6a6897
Update packages/core/src/server/assets-middleware/middleware.ts
chenjiahan Oct 23, 2025
6258eee
fix
chenjiahan Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 21 additions & 11 deletions packages/core/src/server/assets-middleware/middleware.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,20 @@ function sendError(
};

const content = errorMessages[code];
const message = `${code} ${content}`;
const document = Buffer.from(
`<!DOCTYPE html>\n<html lang="en">\n<head>\n<meta charset="utf-8">\n<title>Error</title>\n</head>\n<body>\n<pre>${content}</pre>\n</body>\n</html>`,
`<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="utf-8">
<title>${message}</title>
</head>
<body>
<h1 style="text-align: center;">${message}</h1>
<hr>
<div style="text-align: center;">Rsbuild dev server</div>
</body>
</html>`,
'utf-8',
);

Expand All @@ -143,7 +155,6 @@ function sendError(

res.statusCode = code;
res.setHeader('Content-Type', 'text/html; charset=utf-8');
res.setHeader('Content-Security-Policy', "default-src 'none'");
res.setHeader('X-Content-Type-Options', 'nosniff');

const byteLength = Buffer.byteLength(document);
Expand Down Expand Up @@ -302,21 +313,20 @@ export function createMiddleware(
}

function getRangeHeader(): string | undefined {
const rage = req.headers.range;
if (rage && BYTES_RANGE_REGEXP.test(rage)) {
return rage;
const { range } = req.headers;
if (range && BYTES_RANGE_REGEXP.test(range)) {
return range;
}
}

function getOffsetAndLenFromRange(range: Range): [number, number] {
const offset = range.start;
const len = range.end - range.start + 1;
return [offset, len];
const { start, end } = range;
const len = end - start + 1;
return [start, len];
}

function calcStartAndEnd(offset: number, len: number): [number, number] {
const start = offset;
const end = Math.max(offset, offset + len - 1);
function calcStartAndEnd(start: number, len: number): [number, number] {
const end = Math.max(start, start + len - 1);
return [start, end];
}

Expand Down
Loading