refactor(assets-middleware): remove unused utility functions#6411
Merged
chenjiahan merged 1 commit intomainfrom Oct 23, 2025
Merged
refactor(assets-middleware): remove unused utility functions#6411chenjiahan merged 1 commit intomainfrom
chenjiahan merged 1 commit intomainfrom
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes two unused utility functions (memorize and escapeHtml) from the assets middleware to simplify the codebase. The change is based on the observation that error messages are fixed content that don't require HTML escaping.
Key changes:
- Removed the
memorizewrapper fromparseRangeHeadersfunction - Removed HTML escaping from error message rendering
- Deleted two utility files that are no longer needed
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/core/src/server/assets-middleware/middleware.ts | Removed imports and usage of memorize and escapeHtml utilities |
| packages/core/src/server/assets-middleware/memorize.ts | Deleted memoization utility file |
| packages/core/src/server/assets-middleware/escapeHtml.ts | Deleted HTML escaping utility file |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Remove
memorizeandescapeHtmlutilities from the assets middleware as they don't really need to be used.The
contentare fixed error messages and do not need to be escaped.Checklist