Skip to content

fix(server): replace unescape with decodeURIComponent #6408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chenjiahan merged 1 commit into from
Oct 22, 2025
Merged

fix(server): replace unescape with decodeURIComponent #6408

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions packages/core/src/server/assets-middleware/getFileFromUrl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,19 @@
import type { Stats as FSStats } from 'node:fs';
import path from 'node:path';
import { unescape as qsUnescape } from 'node:querystring';
import { getPathnameFromUrl } from '../../helpers/path';
import type { InternalContext } from '../../types';
import type { OutputFileSystem } from './index';

const UP_PATH_REGEXP = /(?:^|[\\/])\.\.(?:[\\/]|$)/;

function decodePath(input: string) {
try {
return decodeURIComponent(input);
} catch {
return input;
}
}

/**
* Resolves URL to file path with security checks and retrieves file from
* the build output directories.
Expand All @@ -18,7 +25,7 @@ export async function getFileFromUrl(
): Promise<
{ filename: string; fsStats: FSStats } | { errorCode: number } | undefined
> {
const pathname = qsUnescape(getPathnameFromUrl(url));
const pathname = decodePath(getPathnameFromUrl(url));

if (!pathname) {
return;
Expand Down
Loading