Skip to content

chore: remove Rspack config schema env variable#6403

Merged
chenjiahan merged 1 commit intomainfrom
remove_schema_variable_1022
Oct 22, 2025
Merged

chore: remove Rspack config schema env variable#6403
chenjiahan merged 1 commit intomainfrom
remove_schema_variable_1022

Conversation

@chenjiahan
Copy link
Member

Summary

Remove the RSPACK_CONFIG_VALIDATE variable, it is no longer used since Rspack v1.6.0-beta.1.

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings October 22, 2025 07:51
@netlify
Copy link

netlify bot commented Oct 22, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 325a29f
🔍 Latest deploy log https://app.netlify.com/projects/rsbuild/deploys/68f88d107dee440008862900
😎 Deploy Preview https://deploy-preview-6403--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 58 (🔴 down 10 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the RSPACK_CONFIG_VALIDATE environment variable handling, which is no longer needed as of Rspack v1.6.0-beta.1. The change cleans up code and documentation that previously managed Rspack's config schema validation.

  • Removed code that sets the environment variable to 'loose-silent' by default
  • Removed documentation sections explaining the config validation behavior
  • Removed explicit 'strict' validation enablement in e2e tests

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
packages/core/src/plugins/basic.ts Removed code that set RSPACK_CONFIG_VALIDATE to 'loose-silent'
website/docs/zh/guide/migration/rsbuild-0-x.mdx Removed Chinese documentation section about Rspack config validation
website/docs/en/guide/migration/rsbuild-0-x.mdx Removed English documentation section about Rspack config validation
e2e/playwright.config.ts Removed RSPACK_CONFIG_VALIDATE environment variable assignment

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chenjiahan chenjiahan merged commit 792e4fa into main Oct 22, 2025
12 checks passed
@chenjiahan chenjiahan deleted the remove_schema_variable_1022 branch October 22, 2025 08:04
@chenjiahan chenjiahan mentioned this pull request Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant