feat(plugin-vue): supersede vue-loader with rspack-vue-loader#6390
Merged
chenjiahan merged 1 commit intoweb-infra-dev:mainfrom Oct 21, 2025
Merged
feat(plugin-vue): supersede vue-loader with rspack-vue-loader#6390chenjiahan merged 1 commit intoweb-infra-dev:mainfrom
chenjiahan merged 1 commit intoweb-infra-dev:mainfrom
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the unmaintained vue-loader dependency with rspack-vue-loader, a maintained fork. The change addresses an issue where vue-loader has locked known properties, preventing the use of the with syntax needed for Rstest's importActual method implementation.
Key changes:
- Replaced
vue-loaderwithrspack-vue-loaderthroughout the codebase - Updated package dependency from
vue-loader@^17.4.2torspack-vue-loader@^17.4.4
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/plugin-vue/package.json | Updated dependency from vue-loader to rspack-vue-loader |
| packages/plugin-vue/src/index.ts | Updated imports and loader resolution to use rspack-vue-loader |
| packages/plugin-vue/src/splitChunks.ts | Updated regex pattern to match rspack-vue-loader in node_modules |
| packages/plugin-vue/tests/snapshots/index.test.ts.snap | Updated test snapshots to reflect new loader path |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This was referenced Oct 21, 2025
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
in Rstest web-infra-dev/rstest#618, introduced a dedicated loader matcher using
withto implement the syncimportActualmethod. however, vue-loader has locked the known properties https://github.com/vuejs/vue-loader/blob/698636508e08f5379a57eaf086b5ff533af8e051/src/pluginWebpack5.ts#L81-L101 so an error will throw when counteringwith.since vue-loader is not maintained anymore, using a forked version vue-loader https://github.com/rspack-contrib/rspack-vue-loader.
Related Links
Checklist