Skip to content

feat(plugin-vue): supersede vue-loader with rspack-vue-loader#6390

Merged
chenjiahan merged 1 commit intoweb-infra-dev:mainfrom
fi3ework:rspack-vue-loader
Oct 21, 2025
Merged

feat(plugin-vue): supersede vue-loader with rspack-vue-loader#6390
chenjiahan merged 1 commit intoweb-infra-dev:mainfrom
fi3ework:rspack-vue-loader

Conversation

@fi3ework
Copy link
Member

Summary

in Rstest web-infra-dev/rstest#618, introduced a dedicated loader matcher using with to implement the sync importActual method. however, vue-loader has locked the known properties https://github.com/vuejs/vue-loader/blob/698636508e08f5379a57eaf086b5ff533af8e051/src/pluginWebpack5.ts#L81-L101 so an error will throw when countering with.

since vue-loader is not maintained anymore, using a forked version vue-loader https://github.com/rspack-contrib/rspack-vue-loader.

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings October 21, 2025 03:02
@netlify
Copy link

netlify bot commented Oct 21, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 6750e48
🔍 Latest deploy log https://app.netlify.com/projects/rsbuild/deploys/68f6f7d263078d0008b3f57f
😎 Deploy Preview https://deploy-preview-6390--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 64 (🟢 up 2 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR replaces the unmaintained vue-loader dependency with rspack-vue-loader, a maintained fork. The change addresses an issue where vue-loader has locked known properties, preventing the use of the with syntax needed for Rstest's importActual method implementation.

Key changes:

  • Replaced vue-loader with rspack-vue-loader throughout the codebase
  • Updated package dependency from vue-loader@^17.4.2 to rspack-vue-loader@^17.4.4

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

File Description
packages/plugin-vue/package.json Updated dependency from vue-loader to rspack-vue-loader
packages/plugin-vue/src/index.ts Updated imports and loader resolution to use rspack-vue-loader
packages/plugin-vue/src/splitChunks.ts Updated regex pattern to match rspack-vue-loader in node_modules
packages/plugin-vue/tests/snapshots/index.test.ts.snap Updated test snapshots to reflect new loader path
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenjiahan chenjiahan merged commit f63f9bd into web-infra-dev:main Oct 21, 2025
12 checks passed
@chenjiahan chenjiahan mentioned this pull request Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants