Skip to content

chore: remove unnecessary lazyBarrel config#6373

Merged
chenjiahan merged 1 commit intomainfrom
remove_lazy_barrel_1017
Oct 17, 2025
Merged

chore: remove unnecessary lazyBarrel config#6373
chenjiahan merged 1 commit intomainfrom
remove_lazy_barrel_1017

Conversation

@chenjiahan
Copy link
Member

Summary

The experiments.lazyBarrel config has been enabled by default in Rspack v1.6.0-beta.0, so it's no longer needed.

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings October 17, 2025 07:23
@netlify
Copy link

netlify bot commented Oct 17, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 7323942
🔍 Latest deploy log https://app.netlify.com/projects/rsbuild/deploys/68f1eed625a2600009aab11e
😎 Deploy Preview https://deploy-preview-6373--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 69 (no change from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the explicit lazyBarrel: true configuration from Rspack experiments since this feature has been enabled by default in Rspack v1.6.0-beta.0, making the manual configuration redundant.

  • Removed lazyBarrel: true from the experiments configuration in the basic plugin
  • Updated test snapshots to reflect the removal of the lazyBarrel configuration

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/core/src/plugins/basic.ts Removed the explicit lazyBarrel: true setting from Rspack experiments configuration
packages/core/tests/snapshots/basic.test.ts.snap Updated snapshots to remove lazyBarrel from basic plugin test outputs
packages/core/tests/snapshots/builder.test.ts.snap Updated snapshots to remove lazyBarrel from builder test outputs
packages/core/tests/snapshots/default.test.ts.snap Updated snapshots to remove lazyBarrel from default plugin test outputs
packages/core/tests/snapshots/environments.test.ts.snap Updated snapshots to remove lazyBarrel from environment configuration test outputs

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@chenjiahan chenjiahan merged commit 0e52475 into main Oct 17, 2025
12 checks passed
@chenjiahan chenjiahan deleted the remove_lazy_barrel_1017 branch October 17, 2025 07:34
@chenjiahan chenjiahan mentioned this pull request Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant