chore(types): add Optional utility type and simplify config types#6361
Merged
chenjiahan merged 1 commit intomainfrom Oct 15, 2025
Merged
chore(types): add Optional utility type and simplify config types#6361chenjiahan merged 1 commit intomainfrom
chenjiahan merged 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new Optional<T, K> utility type to simplify configuration type definitions by making specified properties optional while keeping others required. It refactors several normalized config types to use this new utility instead of verbose combinations of Pick, Omit, Required, and Partial operations.
Key changes:
- Added
Optional<T, K>utility type for cleaner optional property handling - Simplified
NormalizedServerConfig,NormalizedOutputConfig,NormalizedClientConfig, andMergedEnvironmentConfigtype definitions - Reduced code complexity while maintaining the same type behavior
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/core/src/types/utils.ts | Adds the new Optional<T, K> utility type definition |
| packages/core/src/types/config.ts | Imports and applies the new utility type to simplify multiple config type definitions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve several config type definitions file to simplify the way optional properties are handled.
Checklist